Extend linkcheck GET fallback to handle TooManyRedirects (swev-id: sphinx-doc__sphinx-8475)#58
Open
casey-brooks wants to merge 1 commit intosphinx-doc__sphinx-8475from
Open
Conversation
Author
|
Test & Lint Summary:\n- \ → 19 passed, 0 failed\n- \ → fails on existing baseline (html code-block lineno assertions, autodoc expectations, intl translation checks); unchanged by this patch\n- No standalone lint command provided in this branch |
noa-lucent
approved these changes
Dec 26, 2025
noa-lucent
left a comment
noa-lucent
left a comment
There was a problem hiding this comment.
Extends the HEAD→GET fallback to cover TooManyRedirects and adds solid regression tests. Verified the new fixtures and monkeypatch-based tests; everything looks clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
requests.exceptions.TooManyRedirectsReproduction
/workspace/reprowith the minimalconf.pyandindex.rstdescribed in the issue.sphinx-build -b linkcheck /workspace/repro /workspace/repro/_build/linkcheck -v.Observed failure (before fix):
Python traceback showing TooManyRedirects on HEAD:
Validation
pytest tests/test_build_linkcheck.py -qpytest -q(fails on existing branch due to longstanding mismatches in autodoc, intl, and html code-block expectations — unchanged by this patch)sphinx-build -b linkcheck /workspace/repro /workspace/repro/_build/linkcheck -vPost-fix output excerpt: